Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CryptScryptKDF: init at 0.010 #71128

Merged
merged 1 commit into from Oct 20, 2019
Merged

perlPackages.CryptScryptKDF: init at 0.010 #71128

merged 1 commit into from Oct 20, 2019

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 14, 2019

Motivation for this change

Adds the Crypt::ScryptKDF Perl module

(Includes dependency on CryptOpenSSLRandom for RNG)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth

@stigtsp stigtsp force-pushed the package/perl-crypt-scryptkdf-init branch from 51bf92c to 5d56db1 Compare October 19, 2019 02:27
@stigtsp
Copy link
Member Author

stigtsp commented Oct 19, 2019

@volth Thx for all the reviews btw :)

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 20, 2019

@GrahamcOfBorg build perl528Packages.CryptScryptKDF perl530Packages.CryptScryptKDF

@stigtsp stigtsp force-pushed the package/perl-crypt-scryptkdf-init branch from 5d56db1 to 0486eac Compare October 20, 2019 17:03
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 20, 2019

@GrahamcOfBorg build perl528Packages.CryptScryptKDF perl530Packages.CryptScryptKDF

@c0bw3b c0bw3b merged commit 1d6da54 into NixOS:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @c0bw3b