Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cura: fix #71184 #71188

Merged
merged 1 commit into from
Oct 15, 2019
Merged

cura: fix #71184 #71188

merged 1 commit into from
Oct 15, 2019
+1 −1

Conversation

evils
Copy link
Member

@evils evils commented Oct 15, 2019

Motivation for this change

I want cura to work
@HappyEnt pointed out it didn't

Things done

TOFU'd the hash

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar @gebner

Sorry, something went wrong.

@ofborg ofborg bot requested review from abbradar and gebner October 15, 2019 14:35
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 15, 2019
@gebner
Copy link
Member

gebner commented Oct 15, 2019

@GrahamcOfBorg build cura

@gebner gebner merged commit 070dbb7 into NixOS:master Oct 15, 2019
@gebner
Copy link
Member

gebner commented Oct 15, 2019

I'm not sure what happened here. Looking back at the 4.3 update PR (#69435), we changed the hash and GrahamcOfBorg checked it. Maybe upstream changed the release tag in the meantime?

@evils evils deleted the cura-fix branch October 15, 2019 14:45
@evils
Copy link
Member Author

evils commented Oct 15, 2019

that was my guess too
but it seems their last commit under that tag is 1 day older than #69435
atm i'm guessing the hash of a previously cached derivation ended up being used, somehow
maybe @esclear knows better

@esclear
Copy link
Contributor

esclear commented Oct 15, 2019 •
edited
Loading

Hmm, I'm not sure, what happened there, since it worked locally.

Probably I screwed it up when I selected the patches using git add -p.

Sorry :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar

@gebner gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evils @gebner @esclear