Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strongswan: fix build with enableNetworkManager set to true #71186

Merged
merged 1 commit into from
Oct 15, 2019
Merged

strongswan: fix build with enableNetworkManager set to true #71186

merged 1 commit into from
Oct 15, 2019
+2 −2

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 15, 2019

glib doesn't seem to be propagated, and strongswan with networkmanager
fails to build because of that.

Motivation for this change

networkmanager fails to build on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@flokli
strongswan: fix build with enableNetworkManager set to true

Verified

This commit was signed with the committer’s verified signature.
makefu Felix Richter
GPG key ID: 36F7711F3FC0F225
Verified
Learn about vigilant mode
229dc6b 
glib doesn't seem to be propagated, and strongswan with networkmanager
fails to build because of that.
@flokli flokli requested a review from hedning October 15, 2019 14:13
hedning
hedning approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, after 1ff3a0c nm no longer uses dbus-glib, which was propagated.

@flokli flokli merged commit d4c9a09 into NixOS:master Oct 15, 2019
@flokli flokli deleted the fix-strongswan-with-networkmanager branch October 15, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @hedning