Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-deps: init at 1.1.1 #71199

Merged
merged 2 commits into from Oct 16, 2019
Merged

cargo-deps: init at 1.1.1 #71199

merged 2 commits into from Oct 16, 2019

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Oct 15, 2019

Motivation for this change

Describes itself as "an improvement on the unmaintained and buggy cargo-graph," which is in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam marsam merged commit 882dc45 into NixOS:master Oct 16, 2019
@marsam
Copy link
Contributor

marsam commented Oct 16, 2019

Thanks!

@arcnmx arcnmx deleted the pr-cargo-deps branch October 16, 2019 03:04
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 21, 2019
@marsam @dtzWill
Merge pull request NixOS#71199 from arcnmx/pr-cargo-deps
84dfd77 
cargo-deps: init at 1.1.1
(cherry picked from commit 882dc45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arcnmx @marsam