Add: UDP query of game script #7771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reopened from old flyspray issue OpenTTD#6211. Patch adds a possibility to query OpenTTD server for running game scripts and returns its name and version if any present. Goal of this fork is to make also ingame interface.
LordAro
requested changes
Oct 17, 2019
| @@ -32,6 +32,8 @@ enum PacketUDPType { | |||
| PACKET_UDP_CLIENT_GET_NEWGRFS, ///< Requests the name for a list of GRFs (GRF_ID and MD5) | |||
| PACKET_UDP_SERVER_NEWGRFS, ///< Sends the list of NewGRF's requested. | |||
| PACKET_UDP_MASTER_SESSION_KEY, ///< Sends a fresh session key to the client | |||
| PACKET_UDP_CLIENT_GET_GAMESCRIPT,///< Requests the name of a game script | |||
There was a problem hiding this comment.
needs a space separator, or the whole thing needs realigning
| if(info == NULL){ | ||
| packet.Send_uint8(0); | ||
| } | ||
| else{ |
There was a problem hiding this comment.
various codestyle issues with the if here
| /** The return of the client's request of the names of GameScript */ | ||
| void ClientNetworkUDPSocketHandler::Receive_SERVER_GAMESCRIPT(Packet *p, NetworkAddress *client_addr) | ||
| { | ||
| uint8 num_gs; |
There was a problem hiding this comment.
No need to predeclare the variable, just on-use will be fine
| @@ -299,6 +326,7 @@ class ClientNetworkUDPSocketHandler : public NetworkUDPSocketHandler { | |||
| void Receive_SERVER_RESPONSE(Packet *p, NetworkAddress *client_addr) override; | |||
| void Receive_MASTER_RESPONSE_LIST(Packet *p, NetworkAddress *client_addr) override; | |||
| void Receive_SERVER_NEWGRFS(Packet *p, NetworkAddress *client_addr) override; | |||
| void Receive_SERVER_GAMESCRIPT(Packet *p, NetworkAddress *client_addr) override; | |||
There was a problem hiding this comment.
not tab indented (this is why the commit checker is failing)
|
Three things worth mentioning:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened from old flyspray issue #6211.
Patch adds a possibility to query OpenTTD server for running game scripts and returns its name and version if any present.
Goal of this fork is to also create ingame interface.