Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging]pythonPackages.docker: 4.0.2 -> 4.10 #71155

Merged
merged 1 commit into from Oct 16, 2019
Merged

[staging]pythonPackages.docker: 4.0.2 -> 4.10 #71155

merged 1 commit into from Oct 16, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

noticed it was out of date on repology.

ordered propagatedBuildInputs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner October 15, 2019 01:55
@jonringer jonringer changed the base branch from master to staging October 15, 2019 04:14
@jonringer jonringer changed the title pythonPackages.docker: 4.0.2 -> 4.10 [staging]pythonPackages.docker: 4.0.2 -> 4.10 Oct 15, 2019
@jonringer
Copy link
Contributor Author

changed base branch to staging as it was >100 rebuilds

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: qt/kde 2.status: merge conflict labels Oct 15, 2019
@FRidh
Copy link
Member

FRidh commented Oct 15, 2019 •
edited

master is OK. 100 is not much, especially in case of python packages.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg eval

@ofborg ofborg bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: qt/kde 2.status: merge conflict labels Oct 16, 2019
@FRidh FRidh changed the base branch from staging to master October 16, 2019 16:51
@FRidh FRidh changed the base branch from master to python-unstable October 16, 2019 16:51
@FRidh FRidh merged commit 00b934f into NixOS:python-unstable Oct 16, 2019
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: qt/kde labels Oct 16, 2019
@jonringer jonringer deleted the bump-docker branch October 16, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: python 6.topic: qt/kde 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh