Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spidermonkey 60 bump #71174

Merged
merged 2 commits into from Oct 19, 2019
Merged

Spidermonkey 60 bump #71174

merged 2 commits into from Oct 19, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Oct 15, 2019

Motivation for this change

Bump spidermonkey 60, and drop unused 52.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from abbradar October 15, 2019 11:01
@hedning
spidermonkey_60: 60.4.0 -> 60.9.0
231432e 
This is the last 60-esr I believe.

- fixed multiple outputs (saves $out 2MB from $out)
- updated the only patch we carry
- symlinked `js` to `js60`, some packages using spidermonkey expects `js`. Might
  make it possible to drop 38 in the future.
@hedning
spidermonkey_52: drop, as is unused
18d7929 
`gnome-shell-extensions` switched over to `spidermonkey_60` in 3.34 leaving
`spidermonkey_52` unused.
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@worldofpeace worldofpeace merged commit 673a736 into NixOS:staging Oct 19, 2019
@hedning hedning deleted the spidermonkey_60-bump branch October 19, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @worldofpeace @jtojnar