Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpa_supplicant: install d-bus conf correctly to share/dbus/system.d #71113

Merged
merged 1 commit into from Oct 14, 2019
Merged

wpa_supplicant: install d-bus conf correctly to share/dbus/system.d #71113

merged 1 commit into from Oct 14, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Oct 14, 2019 •
edited

Motivation for this change

Fixes 40dda73 which inadvertently installed to
a file as the directory didn't exist.

Also blocked up the postInstall script for readability.

cc @worldofpeace

Things done

Running my system with this fix on top of dd05027.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@hedning
wpa_supplicant: install d-bus conf correctly to share/dbus/system.d
fa5f13c 
Fixes 40dda73 which inadvertently installed to
a file as the directory didn't exist.

Also blocked up the postInstall script for readability.
@jtojnar jtojnar mentioned this pull request Oct 14, 2019
Merged
22 tasks
@hedning hedning merged commit 67effde into NixOS:master Oct 14, 2019
@hedning hedning deleted the fix-wpa-supplicant branch October 14, 2019 16:57
@worldofpeace
Copy link
Contributor

Thanks @hedning 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hedning @worldofpeace