Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: remove deprecated kernel config options #71111

Merged
merged 1 commit into from Oct 15, 2019
Merged

linux: remove deprecated kernel config options #71111

merged 1 commit into from Oct 15, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 14, 2019

Our oldest kernel is 4.4. That's why we can remove configurations that only
applies to kernels older than that.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92
linux: remove deprecated kernel config options
14a6713 
Our oldest kernel is 4.4. That's why we can remove configurations that only
applies to kernels older than that.
@globin globin merged commit 1d651d1 into NixOS:master Oct 15, 2019
@Mic92 Mic92 deleted the linux-cleanup branch October 16, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @teto @globin