pythonPackages.ansible: add support for hcloud #71112
Conversation
|
the commit message sounds confusing, thought you were adding a dependency to the hcloud package |
There was a problem hiding this comment.
I'm not sure about including all the plugins to the default installation... seems like it will eventually make the ansible closure huge. Might be worthwhile to just list the other needed packages alongside the ansible package when you're specifying the environment you want to use the packages in.
@FRidh thoughts?
liff
force-pushed
the
pythonPackages.ansible/add-hcloud
branch
from
4838d35
to
f48693e
Compare
liff
changed the title
|
Sorry for being a noob but I don’t quite understand what you mean by listing the needed packages in the environment? Do you mean something like this? nix run nixpkgs.ansible nixpkgs.python3Packages.hcloud \
-c ansible-inventory -i hcloud.yml --graphIf so, then it doesn’t seem to work, i.e. Ansible cannot find the hcloud package in its python path. |
|
The general approach with Python packages is to use composition using |
|
So rather than installing Ansible with { environment.systemPackages = [ ansible ]; }add it to Python environment: { environment.systemPackages = [ (python3.withPackages (ps: with ps; [ ansible ])) ]; }along with whatever you need to depend on. If so, works for me, thanks! |
Motivation for this change
Using Hetzner Cloud inventory plugin and cloud modules requires the availability of hcloud-python (also: #69151).
A slight caveat is that due to the way Ansible works, using the cloud module on localhost may need something like this to work:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @joamaki @costrouc