Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sshfs: add ssh program to the environment #71072

Merged
merged 1 commit into from Oct 14, 2019
Merged

sshfs: add ssh program to the environment #71072

merged 1 commit into from Oct 14, 2019

Conversation

minijackson
Copy link
Member

Motivation for this change

sshfs calls the "ssh" program, without it being in the closure. For me, this makes the "sftp" plugin of kdeconnect work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Result of nix-review 1
6 package were build:
  • backintime-common (sshfsFuse)
  • kdeconnect (sshfsFuse)
  • rmount (sshfsFuse)
  • sshfs (sshfsFuse)
  • telepresence (sshfsFuse)
  • x2goserver (sshfsFuse)
Notify maintainers

cc @primeos

@ofborg ofborg bot requested a review from primeos October 13, 2019 09:58
@primeos primeos self-assigned this Oct 14, 2019
@primeos
Copy link
Member

primeos commented Oct 14, 2019

LGTM, thanks :)

@primeos primeos merged commit 41ce787 into NixOS:master Oct 14, 2019
@minijackson minijackson deleted the ssh-in-sshfs-env branch October 14, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

Assignees

@primeos primeos

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minijackson @primeos