-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify nixos-test screenshot name. #71123
Conversation
I tried to use a dash in the name, which resulted in a weird error.
You can build the manual locally to check for problems |
Thank you for your contributions.
|
@robinp is this still relevant? |
Based on https://github.com/NixOS/nixpkgs/blob/master/nixos/lib/test-driver/test-driver.py#L565, it seems it still is. |
I marked this as stale due to inactivity. → More info |
Very belatedly: Thanks for spotting this issue, and offering a patch! Is documenting this as a limitation really the right approach? If I understand correctly, what's happening is that the screenshot filename is being interpreted by the shell as two words, or something along those lines. Surely this is fixable by adding quotes somewhere? |
Also since this is PR is pretty stale and needs to be redone completely because of the doc migration, I am going to close it. |
Motivation for this change
I tried to use a dash in the screenshot name, which resulted in a weird error.
Things done
Edited doc. Nothing else done.
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @