Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nox: add missing 'setuptools' to propagatedBuildInputs #71160

Merged
merged 1 commit into from Oct 17, 2019
Merged

nox: add missing 'setuptools' to propagatedBuildInputs #71160

merged 1 commit into from Oct 17, 2019

Conversation

jerith666
Copy link
Contributor

Motivation for this change

As a side-effect of f7e28bf, the build
no longer propagated 'setuptools', which is a run-time dependency. See
#68314 for further details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @madjar @FRidh

@jerith666
nox: add missing 'setuptools' to propagatedBuildInputs
ce3ddb2 
As a side-effect of f7e28bf, the build
no longer propagated 'setuptools', which is a run-time dependency. See
NixOS#68314 for further details.
@mmahut
Copy link
Member

mmahut commented Oct 16, 2019

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from madjar October 16, 2019 19:26
@madjar madjar merged commit 83be1d4 into NixOS:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madjar madjar madjar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerith666 @mmahut @madjar