Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager: enable polkit_agent #71163

Merged
merged 1 commit into from Oct 18, 2019
Merged

networkmanager: enable polkit_agent #71163

merged 1 commit into from Oct 18, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Not sure why we had this disabled.
This is for the nmcli/nmtui agent subcommand 0
which allows it to act as a polkit agent.

nmcli agent { secret | polkit | all }
Run nmcli as a NetworkManager secret agent, or polkit agent.

For example, this is useful if you want to use nmcli/nmtui to authenti-
cate with polkit on a headless server.

Thanks for verifying my findings in #nm @jtojnar 馃憤

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
networkmanager: enable polkit_agent
15b0cff 
Not sure why we had this disabled.
This is for the nmcli/nmtui `agent` subcommand [0]
which allows it to act as a polkit agent.

> nmcli agent { secret | polkit | all }
> Run nmcli as a NetworkManager secret agent, or polkit agent.

For example, this is useful if you want to use nmcli/nmtui to authenti-
cate with polkit on a headless server.

[0]: https://developer.gnome.org/NetworkManager/stable/nmcli.html
@jtojnar
Copy link
Contributor

jtojnar commented Oct 15, 2019

What is the closure size effect on packages depending on libnm? Polkit depends on mozjs, doesn't it?

@worldofpeace
Copy link
Contributor Author

What is the closure size effect on packages depending on libnm? Polkit depends on mozjs, doesn't it?

I believe we already have polkit in buildInputs.

@jtojnar
Copy link
Contributor

jtojnar commented Oct 15, 2019

That one does not stay in the runtime closure. Though, we do get it through ModemManager, which depends on libpolkit-gobject, so I retract my objection.

@worldofpeace worldofpeace merged commit 1cb8e5d into NixOS:staging Oct 18, 2019
@worldofpeace worldofpeace deleted the nm-polkit-agent branch October 18, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@Phreedom Phreedom Awaiting requested review from Phreedom

@obadz obadz Awaiting requested review from obadz

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar