Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python38: fix build on macOS #71165

Merged
merged 1 commit into from
Oct 15, 2019
Merged

python38: fix build on macOS #71165

merged 1 commit into from
Oct 15, 2019
+3 −2

Conversation

strager
Copy link
Contributor

@strager strager commented Oct 15, 2019

Motivation for this change

Python 3.8 fails to build on macOS for two reasons:

  • python-3.x-distutils-C++.patch fails to apply cleanly.

  • An #include for <util.h> is missing, causing a build failure:

    ./Modules/posixmodule.c:6586:9: error: implicit declaration of function 'openpty' is invalid in C99
    if (openpty(&master_fd, &slave_fd, NULL, NULL, NULL) != 0)
    ^

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

Sorry, something went wrong.

@strager
python38: fix build on macOS
e3b7405 
Python 3.8 fails to build on macOS for two reasons:

* python-3.x-distutils-C++.patch fails to apply cleanly.
* An #include for <util.h> is missing, causing a build failure:

    ./Modules/posixmodule.c:6586:9: error: implicit declaration of function 'openpty' is invalid in C99
        if (openpty(&master_fd, &slave_fd, NULL, NULL, NULL) != 0)
            ^

Use the correct version of python-3.x-distutils-C++.patch, and add a
patch to #include <util.h>.
@strager strager requested a review from FRidh as a code owner October 15, 2019 04:55
KamilaBorowska
KamilaBorowska approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@KamilaBorowska KamilaBorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on NixOS, built with nix-review pr, checked all executables.

@FRidh
Copy link
Member

FRidh commented Oct 15, 2019

@GrahamcOfBorg build python38

@FRidh FRidh merged commit 81d1594 into NixOS:master Oct 15, 2019
@marsam marsam mentioned this pull request Oct 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilaBorowska KamilaBorowska

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@strager @FRidh @KamilaBorowska