Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: 2.2.0 -> 2.5.2, distributed: 2.4.0 -> 2.5.2, dask-ml: 0.11.0 -> 1.0.0, dask-jobqueue: 0.4.1 -> 0.7.0 #71141

Closed
wants to merge 4 commits into from
Closed

dask: 2.2.0 -> 2.5.2, distributed: 2.4.0 -> 2.5.2, dask-ml: 0.11.0 -> 1.0.0, dask-jobqueue: 0.4.1 -> 0.7.0 #71141

wants to merge 4 commits into from

Conversation

francescocarzaniga
Copy link

@francescocarzaniga francescocarzaniga commented Oct 14, 2019 •
edited

Motivation for this change

Dask and relative packages were quite outdated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh @costrouc

@ofborg ofborg bot requested review from teh and costrouc October 14, 2019 20:48
@teh
Copy link
Contributor

teh commented Oct 15, 2019

Thanks for the changes! Would you mind splitting out each update to its own commit? That makes it easier for tooling that uses the commit format, and also to selectively back out if something goes wrong.

@francescocarzaniga
Copy link
Author

@teh No problem, there are now four commits.

@teh
Copy link
Contributor

teh commented Oct 15, 2019

apologies, one more commit style change suggestion: distributed: 2.4.0->2.5.2 to distributed: 2.4.0 -> 2.5.2 (check the git commit log of nixpkgs for other examples). LGTM otherwise, thanks!

@FRidh
Copy link
Member

FRidh commented Oct 17, 2019

@GrahamcOfBorg build python3.pkgs.dask python3.pkgs.distributed python3.pkgs.dask-ml python3.pkgs.dask-jobqueue

@FRidh
Copy link
Member

FRidh commented Oct 17, 2019

apologies, one more commit style change suggestion: distributed: 2.4.0->2.5.2 to distributed: 2.4.0 -> 2.5.2 (check the git commit log of nixpkgs for other examples). LGTM otherwise, thanks!

Even better, prefix with the package set so it is an actual attribute path. That way the bot can pick it up.

@francescocarzaniga
Copy link
Author

So what do I have to do to get these packages updated? It's been ten days and I see that dask has already been replaced in master.

@teh
Copy link
Contributor

teh commented Oct 24, 2019

@francescocarzaniga I think roughly:

  1. resolve conflict
  2. prefix packages e.g. pythonPackages.dask-ml
  3. ping @FRidh to merge

@FRidh FRidh self-assigned this Nov 14, 2019
@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

Nothing happening so closing.

@FRidh FRidh closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh teh teh approved these changes

@costrouc costrouc costrouc approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@francescocarzaniga @teh @FRidh @costrouc @Janik-Haag