Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel_0_4, envoy: remove #71131

Merged
merged 2 commits into from Oct 14, 2019
Merged

bazel_0_4, envoy: remove #71131

merged 2 commits into from Oct 14, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 14, 2019 •
edited

Motivation for this change

This old version of envoy is the only reason we ship bazel_0_4. bazel_0_4 however fails to build since 2018-04-29 (and was marked as broken due to that) - so nobody seems to be using envoy.

It might be the best to just remove that package instead of keeping broken stuff.

Closes #49574.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
envoy: remove
e880a76 
bazel_0_4 fails to build since 2018-04-29, so envoy can't build anymore
too.
@flokli
bazel_0_4: remove
f7b2396 
bazel_0_4 fails to build since 2018-04-29, so clearly nobody is using
it.
@flokli flokli mentioned this pull request Oct 14, 2019
Closed
@Profpatsch
Copy link
Member

Profpatsch commented Oct 14, 2019 •
edited

@GrahamcOfBorg build bazel

(checking whether the main drv still works)

@Profpatsch Profpatsch merged commit 0fd1df7 into NixOS:master Oct 14, 2019
@flokli flokli mentioned this pull request Oct 14, 2019
Closed
10 tasks
@flokli flokli deleted the remove-envoy-bazel_0_4 branch October 14, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann aherrmann Awaiting requested review from aherrmann

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@guibou guibou Awaiting requested review from guibou

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

envoy is out of date
2 participants
@flokli @Profpatsch