New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vlc: fix GLib-GIO-ERROR rg.gtk.Settings.FileChooser #75851
Conversation
On gnome 3.34, attempting to open a file from the VLC media menu causes the following error. (vlc:22800): GLib-GIO-ERROR **: 10:08:13.004: Settings schema 'org.gtk.Settings.FileChooser' does not contain a key named 'show-type-column' Trace/breakpoint trap (core dumped) Adding the wrapQtAppsHook allows gnome access to this schema setting.
cc @jtojnar |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/firefox-crashes-when-opening-a-file-dialog-in-pantheon/5323/1 |
We would need to prevent double-wrapping, see https://nixos.org/nixpkgs/manual/#ssec-gnome-common-issues-double-wrapped. |
I got a bit stuck trying to prevent the double wrapping. I tried the method mentioned in the manual for Qt apps but this did not seem to apply any of prefixes specified in
which did add the correct arguments to two of the binaries ( When using the double wrapped setup, the I'm not quite sure where to go from here. I checked through the repository for similar cases and it seems that these two solutions are commonly used, but neither worked out.
I also tried the following
|
Sorry, there might be more issues: #76283 (comment) I guess double wrapping will have to do for now. |
At the moment the double wrapping works as it solves the open file schema issue mentioned in PR 75851, but in the future we want to prevent the binaries in the vlc package from being wrapped by both the qtWrapperArgs and gappsWrapperArgs.
I added a note about the double wrapping to remember in the future. |
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
Closing due to ghost user. |
Motivation for this change
When clicking on the "Media -> Open File ..." item in the GUI VLC player, the player crashes with the following error.
Adding
wrapGAppsHook
to thenativeBuildInputs
resolves the issue and allows users to select a file.Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandbox
innix.conf
on non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) (no tests exist)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nix-review --run "nix-review wip"
The following derivation could not be built.
The
nix-review
command generated the following report.Tested execution of all binary files (usually in
./result/bin/
)All run except the wrapper, which seems to attempt to call the wrong subwrapper. Potentially it should be calling
.vlc-wrapped
instead of.vlc-wrapper
Determined the impact on package closure size (by running
nix path-info -S
before and after)Ensured that relevant documentation is up to date (does not seem to have any documentation)
Fits CONTRIBUTING.md.
Notify maintainers
No maintainers specified in the .nix file, but the following contributor approved the last VLC PR.
cc @aanderse