Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "python: gym: 0.15.3 -> 0.15.4" #75802

Merged
merged 1 commit into from Dec 17, 2019
Merged

Revert "python: gym: 0.15.3 -> 0.15.4" #75802

merged 1 commit into from Dec 17, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 16, 2019 •
edited

Motivation for this change

This package was prematurely updated as part of updating the package set for python3.8

0.15.4 requires python-opencv, which isn't packaged yet,
and is not trival to package

This reverts commit 8ee4062480e78f17f47c0e9893c6e16fdff35b73.

closes: #75749

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

technically, these are all broken on master :)

8 built (2 failed), 258 copied (2260.6 MiB), 783.3 MiB DL]
error: build of '/nix/store/jpn71f3m0l5wk6zfs6sya83vh25bw64x-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/75802
2 package failed to build:
python37Packages.rl-coach python38Packages.baselines

6 package were built:
python27Packages.gym python37Packages.baselines python37Packages.gym python37Packages.roboschool python38Packages.gym python38Packages.roboschool

@jonringer
Revert "python: gym: 0.15.3 -> 0.15.4"
8a74626 
0.15.4 requires python-opencv, which isn't packaged yet,
and is not trival to package

This reverts commit 8ee4062.
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.gym python37Packages.baselines python37Packages.gym python37Packages.roboschool python38Packages.gym python38Packages.roboschool

@jonringer
Copy link
Contributor Author

failures unrelated to PR

@jonringer jonringer merged commit ef3756f into NixOS:master Dec 17, 2019
@jonringer jonringer deleted the revert-gym branch December 17, 2019 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer