Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecl: fix build with libffi 3.3 #75801

Merged
merged 1 commit into from Dec 16, 2019
Merged

ecl: fix build with libffi 3.3 #75801

merged 1 commit into from Dec 16, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 16, 2019 •
edited

Motivation for this change

The build was broken by the recent libffi update
(53a04a2) because of this upstream
change:

libffi/libffi@ef76205

I have changed the usage of FFI_SYSV as gentoo suggests:

https://wiki.gentoo.org/wiki/Libffi_3.3_porting_notes/FFI_SYSV

I'm not entirely sure if that is the right call here, but I haven't
noticed any regressions in my testing and its definitely better than a
broken build.

Upstream: https://gitlab.com/embeddable-common-lisp/ecl/issues/302

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@timokau
ecl: fix build with libffi 3.3
00c3761 
The build was broken by the recent libffi update
(53a04a2) because of this upstream
change:

libffi/libffi@ef76205

I have changed the usage of FFI_SYSV as gentoo suggests:

https://wiki.gentoo.org/wiki/Libffi_3.3_porting_notes/FFI_SYSV

I'm not entirely sure if that is the right call here, but I haven't
noticed any regressions in my testing and its definitely better than a
broken build.

Upstream: https://gitlab.com/embeddable-common-lisp/ecl/issues/302
@timokau timokau mentioned this pull request Dec 16, 2019
Merged
10 tasks
@ofborg ofborg bot requested a review from 7c6f434c December 16, 2019 22:24
@timokau timokau merged commit db59e94 into NixOS:master Dec 16, 2019
@timokau timokau deleted the ecl-libffi-abi branch December 16, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau