Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tuir: init at 1.28.03 #75817

Merged
merged 2 commits into from Jan 11, 2020
Merged

tuir: init at 1.28.03 #75817

merged 2 commits into from Jan 11, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 17, 2019 •
edited

Motivation for this change

rtv is no longer maintained. tuir is one of the suggested alternatives, seems to be maintained and advancing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer @wedens

Feel free to let me know if you want to also maintain this package.

This change is Reviewable

@matthiasbeyer
Copy link
Contributor

Sad to see rtv die. Is there a process to deprecate the package in nixpkgs?

Feel free to add me as maintainer!

@Br1ght0ne Br1ght0ne mentioned this pull request Dec 17, 2019
Closed
10 tasks
matthiasbeyer
matthiasbeyer requested changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite the commit with my correct email address (see my profile).

@wedens
Copy link

wedens commented Dec 17, 2019 •
edited

@filalex77 Just curious, is there any particular reason you decided to go with tuir and not ttrv which seems to be another active rtv fork?

(I didn't know about any of them until now)

sikmir
sikmir requested changes Dec 30, 2019
View reviewed changes
pkgs/applications/misc/tuir/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tuir/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tuir/default.nix Outdated Show resolved Hide resolved
Br1ght0ne and others added 2 commits December 30, 2019 17:33
@Br1ght0ne @sikmir
tuir: init at 1.28.03
84e0fbf 
Co-authored-by: Nikolay Korotkiy <sikmir@gmail.com>
@Br1ght0ne @matthiasbeyer
tuir: add matthiasbeyer as a maintainer
687e31c 
Co-authored-by: Matthias Beyer <mail@beyermatthias.de>
@Br1ght0ne
Copy link
Member Author

Thanks @sikmir!

@aanderse aanderse merged commit 708a177 into NixOS:master Jan 11, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 12, 2020
@aanderse @dtzWill
Merge pull request NixOS#75817 from filalex77/tuir-1.28.3
6ac6fa9 
tuir: init at 1.28.03
(cherry picked from commit 708a177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer requested changes

@sikmir sikmir sikmir approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Br1ght0ne @matthiasbeyer @wedens @sikmir @aanderse