Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.casbin: init at 0.8.3 #75783

Merged
merged 1 commit into from Dec 17, 2019
Merged

python3Packages.casbin: init at 0.8.3 #75783

merged 1 commit into from Dec 17, 2019

Conversation

costrouc
Copy link
Member

Motivation for this change

Adding poplular authorization library for python. Full test suite runs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.casbin

@costrouc costrouc changed the title pythonPackages.casbin: init at 0.8.3 python3Packages.casbin: init at 0.8.3 Dec 16, 2019
jonringer
jonringer approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[4 built, 6 copied (0.3 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75783
2 package were built:
python37Packages.casbin python38Packages.casbin

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.casbin python38Packages.casbin

@jonringer
Copy link
Contributor

@costrouc please take a look at #75744

@costrouc
Copy link
Member Author

Ready for merge

@jonringer jonringer merged commit 9b372dc into NixOS:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@costrouc @jonringer