Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerTools.buildLayeredImage: update maxlayers from 24 to 100 to match documentation #75779

Merged
merged 1 commit into from Dec 16, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 16, 2019

mkManyPureLayers already was changed, and this function was not updated.

Motivation for this change

Layered images are much more efficient if a maximum number of paths get put in to their own layer. We want to keep some space for extension, but 20 should be plenty.

Things done

Build an image with pkgs.hello pkgs.mysql pkgs.postgresql inside and confirmed it had 100 layers by default.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

…ch documentation

mkManyPureLayers already was changed, and this function was not updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant