Update mailman, postorius, and hyperkitty to their respective latest versions #75782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package is a dependency of GNU Mailman 3.3.x.
jonringer
reviewed
Dec 16, 2019
| @@ -0,0 +1,19 @@ | |||
| { buildPythonPackage, fetchPypi, lib, authres, dnspython, dkimpy, publicsuffix }: | |||
There was a problem hiding this comment.
Suggested change
| { buildPythonPackage, fetchPypi, lib, authres, dnspython, dkimpy, publicsuffix }: | |
| { buildPythonPackage, fetchPypi, lib, isPy27, authres, dnspython, dkimpy, ipaddress, publicsuffix }: |
| sha256 = "0hf1p6ws3jma608pmcb5qsl58xg33wz2s51qqzi9zix0llcnyc97"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ authres dnspython dkimpy publicsuffix ]; |
There was a problem hiding this comment.
Suggested change
| propagatedBuildInputs = [ authres dnspython dkimpy publicsuffix ]; | |
| propagatedBuildInputs = [ | |
| authres | |
| dnspython | |
| dkimpy | |
| publicsuffix | |
| ] ++ lib.optionals isPy27 [ ipaddress ]; |
to avoid:
Requirement already satisfied: authres>=1.2.0 in /nix/store/7bxi2wk1p6ppzc8ir9m63ga5xdm2kazn-python2.7-authres-1.2.0/lib/python2.7/site-packages (from authheaders==0.12.1) (1.2.0)
ERROR: Could not find a version that satisfies the requirement ipaddress (from authheaders==0.12.1) (from versions: none)
ERROR: No matching distribution found for ipaddress (from authheaders==0.12.1)
|
@GrahamcOfBorg build python3Packages.mailman python3Packages.hyperkitty python3Packages.postorius python3Packages.authheaders python2Packages.authheaders |
|
@peti please take a look at my suggestions, as they fix your python2 authheaders package |
|
Needs this commit cherry-picked to make Hyperkitty build. |
|
don't forgot to add a comment to the patch describing what it's doing: Ironically, this is related to networkx/networkx#3750 |
This was referenced Jan 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this update broke the test suite of
postorious. I have no idea why, but it seems like the suite attempts to connect to some local service that's not running in the Nix build sandbox.