weechat: Fix build on Darwin #75785
Merged
weechat: Fix build on Darwin #75785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
vrthra,
lheckemann,
the-kenny,
lovek323 and
Ma27
marsam
reviewed
Dec 16, 2019
|
I think this should be split in two commits. The TCL change on darwin looks isolated from the weechat change. Probably a good idea to move this through staging first as well. |
eraserhd
changed the title
eraserhd
force-pushed
the
weechat-darwin-fix
branch
from
f355172
to
67bed0c
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 501+
10.rebuild-darwin: 501-1000
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The weechat version update from 8 days ago broke building on Darwin for two reasons.
First,
gettextis necessary to build on Darwin.Second, the
tclderivation assumes dll names end in.soon every platform, causing it to make a dangling symlink on Darwin. The weechat changelog indicates that they change how they detect the TCL library -- as a result, weechat attempted to link against the dangling symlink and failed.Things done
I was careful to ensure the TCL derivation evaluate the same on Linux.
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
weechat: cc @lovek323 @the-kenny @lheckemann @Ma27
tcl: @vrthra