Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nixos-option: "See also configuration.nix manpage" in nixos-option manpage #75787

Merged
merged 1 commit into from Dec 19, 2019
Merged

nixos/nixos-option: "See also configuration.nix manpage" in nixos-option manpage #75787

merged 1 commit into from Dec 19, 2019

Conversation

chkno
Copy link
Member

@chkno chkno commented Dec 16, 2019

Motivation for this change

man configuration.nix is of interest to anyone reading man nixos-option

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@chkno chkno requested a review from nbp as a code owner December 16, 2019 19:29
@chkno chkno force-pushed the see-also-man-configuration-dot-nix branch from 0edd38e to 0b3a513 Compare December 18, 2019 20:03
@chkno chkno force-pushed the see-also-man-configuration-dot-nix branch from 0b3a513 to 55eb76a Compare December 18, 2019 20:03
@chkno chkno requested a review from Ma27 December 18, 2019 20:04
@Ma27 Ma27 merged commit 4b51d13 into NixOS:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chkno @Ma27