python: remove _manylinux.py #75763
Merged
python: remove _manylinux.py #75763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
approved these changes
Dec 16, 2019
|
As discussed, the change is good, however, I would like the commit to describe a bit more the motivation (so what we discussed per chat). |
Yeah, will update that once we have that ;) |
This will turn manylinux support back on by default. PIP will now do runtime checks against the compatible glibc version to determine if the current interpreter is compatible with a given manylinux specification. However it will not check if any of the required libraries are present. The motivation here is that we want to support building python packages with wheels that require manylinux support. There is no real change for users of source builds as they are still buildings packages from source. The real noticeable(?) change is that impure usages (e.g. running `pip install package`) will install manylinux packages that previously refused to install. Previously we did claim that we were not compatible with manylinux and thus they wouldn't be installed at all. Now impure users will have basically the same situation as before: If you require some wheel only package it didn't work before and will not properly work now. Now the program will fail during runtime vs during installation time. I think it is a reasonable trade-off since it allows us to install manylinux packages with nix expressions and enables tools like poetry2nix. This should be a net win for users as it allows wheels, that we previously couldn't really support, to be used.
andir
force-pushed
the
manylinux-interp
branch
from
9cbdc31
to
e9f522e
Compare
gilligan
added a commit
to nix-community/poetry2nix
that referenced
this pull request
Dec 16, 2019
As per NixOS/nixpkgs#75763 this environment variable is not needed anymore. Instead python interpreters are now assuming compatibility by default.
|
@FRidh let me know if the current commit message is good enough |
|
Commit message looks good to me! Maybe also add an entry in the change log. |
jonringer
approved these changes
Dec 16, 2019
andersk
approved these changes
Dec 16, 2019
10 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @FRidh