Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonata: fix runtime error #75762

Merged
merged 1 commit into from Dec 16, 2019
Merged

sonata: fix runtime error #75762

merged 1 commit into from Dec 16, 2019

Conversation

eonpatapon
Copy link
Contributor

Currently sonata fails to run with this error:

$ sonata 
/nix/store/b1f3r3g9lpmn591fpk40syrh4m80y971-sonata-1.7b1/lib/python3.7/site-packages/sonata/launcher.py:159: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '3.0') before import to ensure that the right version gets loaded.
  from gi.repository import Gtk, Gdk
Traceback (most recent call last):
  File "/nix/store/b1f3r3g9lpmn591fpk40syrh4m80y971-sonata-1.7b1/bin/..sonata-wrapped-wrapped", line 9, in <module>
    sys.exit(run())
  File "/nix/store/b1f3r3g9lpmn591fpk40syrh4m80y971-sonata-1.7b1/lib/python3.7/site-packages/sonata/launcher.py", line 186, in run
    from sonata import main
  File "/nix/store/b1f3r3g9lpmn591fpk40syrh4m80y971-sonata-1.7b1/lib/python3.7/site-packages/sonata/main.py", line 38, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

Adding setuptools to propagatedBuildInputs fixes it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rvl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants