Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 79.0.3945.79 -> 79.0.3945.88 #75853

Merged
merged 1 commit into from Dec 19, 2019
Merged

chromium: 79.0.3945.79 -> 79.0.3945.88 #75853

merged 1 commit into from Dec 19, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 18, 2019 •
edited

Motivation for this change

https://chromereleases.googleblog.com/2019/12/stable-channel-update-for-desktop_17.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bendlas @thefloweringash

@thefloweringash
Copy link
Member

chromium builds and runs on aarch64. 👍 Haven't tested chromiumBeta or chromiumDev (yet).

@ivan
Copy link
Member Author

ivan commented Dec 18, 2019

I tested chromium on NixOS master x86_64; YouTube, audio output, gmail, github are OK.

Please merge.

@nh2 nh2 merged commit b961338 into NixOS:master Dec 19, 2019
@nh2
Copy link
Contributor

nh2 commented Dec 19, 2019

Fixes:

CVE-2019-13767: Use after free in media picker.

@mebubo mebubo mentioned this pull request Jan 11, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @thefloweringash @nh2