New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lumpy, sambamba, and samblaster #75843
Conversation
Please put each package in a different PR, and format the PR title to match the commit message - use e.g |
Lumpy depends on sambamba and samblaster so it makes sense to have them in one PR as lumpy would be broken if by itself. I have done similar PRs in the past without issues, are you sure you want to split them? |
On a 2nd thought, I guess it's OK :). |
be169a7
to
0341ec4
Compare
Anything else I need to do to get this merged? |
Now I see there's a CI error. |
Weird, the hash changed. Fixed hash and rebased against latest master. |
Result of 3 packages built:
|
Sorry for the long wait and thanks for your contribution. |
Motivation for this change
Add lumpy and prerequisites to nixpkgs.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)