Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emscripten: 1.38.28 -> 1.39.1 #75849

Closed
wants to merge 2 commits into from
Closed

emscripten: 1.38.28 -> 1.39.1 #75849

wants to merge 2 commits into from

Conversation

nkpart
Copy link
Contributor

@nkpart nkpart commented Dec 18, 2019

Motivation for this change

It's been almost a year since the last emscripten update. 1.39.1 is the latest release that has matching version releases of emscripten and binaryen.

Things done

Tested via nix-build default.nix -A emscriptenPackages on Linux and macOS.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@leo60228
Copy link
Member

leo60228 commented Jul 7, 2020

1.39.0 deprecates the emscripten-fastcomp LLVM fork, replacing it with upstream LLVM master. 10.0.0 is too old and won't work.

@breakds
Copy link
Contributor

breakds commented Jul 12, 2020

I am a bit confused, not sure whether this is the right place to ask questions but I'd like to try :)

  1. It seems to me that even without this PR the version specified in master branch is already 1.39.1
  2. However, when nix-build the master, it produces em++ and emcc with version 1.38.24
  3. On the other hand I am looking for emscripten > 1.39.9 for a breaking change. Should we go directly to a higher version? How I can help?

Thanks!

@magnetophon
Copy link
Member

When I manually apply 58714da, I get:

building '/nix/store/734iyf5p8nbc3ld1cjmjk6vqj18vk9l2-emscripten-1.39.1.drv'...
--------------- running test -----------------
cache:INFO: generating system asset: is_vanilla.txt... (this will be cached in "/build/.emscripten_cache/is_vanilla.txt" for subsequent builds)
cache:INFO:  - ok
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tests/runner.py:WARNING: use EMTEST_ALL_ENGINES=1 in the env to run against all JS engines, which is slower but provides more coverage
WARNING: no 'numpy' module, HyBi protocol will be slower
Test suites:
['test_core']
Running test_core: (1 tests)
(checking sanity from test runner)
shared:INFO: (Emscripten: Running sanity checks)
test_hello_world (test_core.wasm0) ... cache:INFO: generating system library: libc.bc... (this will be cached in "/build/.emscripten_cache/asmjs/libc.bc" for subsequent builds)
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/errno/strerror.c:3:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/locale_impl.h:7:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/pthread_impl.h:10:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/atomic.h:6:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/atomic_arch.h:5:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten.h:1:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten/emscripten.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL.h:72:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_main.h:25:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_stdinc.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config.h:45:
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config_minimal.h:37:22: error: typedef redefinition with different types ('unsigned int' vs 'unsigned long')
typedef unsigned int size_t;
                     ^
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/bits/alltypes.h:120:24: note: previous definition is here
typedef unsigned _Addr size_t;
                       ^
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/errno/strerror.c:3:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/locale_impl.h:7:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/pthread_impl.h:10:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/atomic.h:6:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/atomic_arch.h:5:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten.h:1:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten/emscripten.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL.h:72:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_main.h:25:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_stdinc.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config.h:45:
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config_minimal.h:44:26: error: typedef redefinition with different types ('long long' vs 'long')
typedef signed long long int64_t;
                         ^
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/bits/alltypes.h:171:25: note: previous definition is here
typedef _Int64          int64_t;
                        ^
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/errno/strerror.c:3:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/locale_impl.h:7:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/pthread_impl.h:10:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/atomic.h:6:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/atomic_arch.h:5:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten.h:1:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten/emscripten.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL.h:72:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_main.h:25:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_stdinc.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config.h:45:
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config_minimal.h:45:28: error: typedef redefinition with different types ('unsigned long long' vs 'unsigned long')
typedef unsigned long long uint64_t;
                           ^
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/bits/alltypes.h:196:25:In file included from  /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/errno/__errno_location.cnote:1: :
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/pthread_impl.h:10:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/atomic.h:6previous definition is here:

In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/atomic_arch.h:5:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten.h:1:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten/emscripten.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL.h:72:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_main.h:25:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_stdinc.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config.h:45:
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config_minimal.h:37:22: error: typedef redefinition with different types ('unsigned int' vs 'unsigned long')
typedef unsigned int size_t;
                     ^
typedef unsigned _Int64 uint64_t;
                        ^
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/bits/alltypes.h:120:24: note: previous definition is here
typedef unsigned _Addr size_t;
                       ^
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/errno/__errno_location.c:1:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/pthread_impl.h:10:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/atomic.h:6:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/atomic_arch.h:5:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten.h:1:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten/emscripten.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL.h:72:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_main.h:25:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_stdinc.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config.h:45:
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config_minimal.h:44:26: error: typedef redefinition with different types ('long long' vs 'long')
typedef signed long long int64_t;
                         ^
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/bits/alltypes.h:171:25: note: previous definition is here
typedef _Int64          int64_t;
                        ^
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/errno/__errno_location.c:1:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/pthread_impl.h:10:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal/atomic.h:6:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/atomic_arch.h:5:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten.h:1:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/emscripten/emscripten.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL.h:72:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_main.h:25:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_stdinc.h:31:
In file included from /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config.h:45:
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL/SDL_config_minimal.h:45:28: error: typedef redefinition with different types ('unsigned long long' vs 'unsigned long')
typedef unsigned long long uint64_t;
                           ^
/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten/bits/alltypes.h:196:25: note: previous definition is here
typedef unsigned _Int64 uint64_t;
                        ^
3 errors generated.
shared:ERROR: '/nix/store/ica8m1bpfsly32hz5dsabwvs6pz357q9-emscriptenfastcomp-1.39.1/bin/clang -target asmjs-unknown-emscripten -D__EMSCRIPTEN_major__=1 -D__EMSCRIPTEN_minor__=39 -D__EMSCRIPTEN_tiny__=1 -D_LIBCPP_ABI_VERSION=2 -Werror=implicit-function-declaration -Xclang -nostdsysteminc -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/libcxx -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libcxxabi/include -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/compat -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/libc -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/local/include -c -Werror -D_XOPEN_SOURCE=700 -Wno-unused-result -Os -fno-builtin -Wno-return-type -Wno-parentheses -Wno-ignored-attributes -Wno-shift-count-overflow -Wno-shift-negative-value -Wno-dangling-else -Wno-unknown-pragmas -Wno-shift-op-parentheses -Wno-string-plus-int -Wno-logical-op-parentheses -Wno-bitwise-op-parentheses -Wno-visibility -Wno-pointer-sign -Wno-absolute-value -Wno-empty-body -I/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal -I/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/js -DEMSCRIPTEN -mllvm -disable-llvm-optzns /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/errno/strerror.c -fno-inline-functions -Xclang -disable-O0-optnone -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL -c -o /build/emscripten_temp_3uklzb/strerror.c.o -emit-llvm' failed (1)
3 errors generated.
shared:ERROR: '/nix/store/ica8m1bpfsly32hz5dsabwvs6pz357q9-emscriptenfastcomp-1.39.1/bin/clang -target asmjs-unknown-emscripten -D__EMSCRIPTEN_major__=1 -D__EMSCRIPTEN_minor__=39 -D__EMSCRIPTEN_tiny__=1 -D_LIBCPP_ABI_VERSION=2 -Werror=implicit-function-declaration -Xclang -nostdsysteminc -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/libcxx -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libcxxabi/include -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/compat -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/libc -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/emscripten -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/local/include -c -Werror -D_XOPEN_SOURCE=700 -Wno-unused-result -Os -fno-builtin -Wno-return-type -Wno-parentheses -Wno-ignored-attributes -Wno-shift-count-overflow -Wno-shift-negative-value -Wno-dangling-else -Wno-unknown-pragmas -Wno-shift-op-parentheses -Wno-string-plus-int -Wno-logical-op-parentheses -Wno-bitwise-op-parentheses -Wno-visibility -Wno-pointer-sign -Wno-absolute-value -Wno-empty-body -I/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal -I/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/js -DEMSCRIPTEN -mllvm -disable-llvm-optzns /nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/errno/__errno_location.c -fno-inline-functions -Xclang -disable-O0-optnone -Xclang -isystem/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/include/SDL -c -o /build/emscripten_temp_3uklzb/__errno_location.c.o -emit-llvm' failed (1)
Traceback (most recent call last):
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/emcc.py", line 3665, in <module>
    sys.exit(run(sys.argv))
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/emcc.py", line 2058, in run
    extra_files_to_link += system_libs.calculate([f for _, f in sorted(temp_files)] + extra_files_to_link, in_temp, stdout_=None, stderr_=None, forced=forced_stdlibs)
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tools/system_libs.py", line 1418, in calculate
    add_library(lib)
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tools/system_libs.py", line 1374, in add_library
    libs_to_link.append((lib.get_path(), need_whole_archive))
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tools/system_libs.py", line 310, in get_path
    return shared.Cache.get(self.get_filename(), self.build)
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tools/cache.py", line 133, in get
    temp = creator()
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tools/system_libs.py", line 350, in build
    create_lib(out_filename, self.build_objects())
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tools/system_libs.py", line 344, in build_objects
    run_commands(commands)
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tools/system_libs.py", line 69, in run_commands
    pool.map_async(run_build_command, commands, chunksize=1).get(999999)
  File "/nix/store/984x0xnjaf00ms5nh1r1ki3h6qd5q399-python-2.7.18/lib/python2.7/multiprocessing/pool.py", line 572, in get
    raise self._value
tools.shared.Py2CalledProcessError: Command '['/nix/store/984x0xnjaf00ms5nh1r1ki3h6qd5q399-python-2.7.18/bin/python', '/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/emcc.py', '-s', 'WASM_OBJECT_FILES=0', '-c', '/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/errno/strerror.c', '-o', '/build/emscripten_temp_3uklzb/strerror.c.o', '-Werror', '-D_XOPEN_SOURCE=700', '-Wno-unused-result', '-Os', '-fno-builtin', '-Wno-return-type', '-Wno-parentheses', '-Wno-ignored-attributes', '-Wno-shift-count-overflow', '-Wno-shift-negative-value', '-Wno-dangling-else', '-Wno-unknown-pragmas', '-Wno-shift-op-parentheses', '-Wno-string-plus-int', '-Wno-logical-op-parentheses', '-Wno-bitwise-op-parentheses', '-Wno-visibility', '-Wno-pointer-sign', '-Wno-absolute-value', '-Wno-empty-body', '-s', 'WASM_OBJECT_FILES=0', '-I/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/src/internal', '-I/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/system/lib/libc/musl/arch/js']' returned non-zero exit status 1
ERROR

======================================================================
ERROR: test_hello_world (test_core.wasm0)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tests/test_core.py", line 121, in decorated
    func(self)
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tests/test_core.py", line 271, in test_hello_world
    self.do_run_in_out_file_test('tests', 'core', 'test_hello_world')
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tests/test_core.py", line 234, in do_run_in_out_file_test
    self.do_run_from_file(src, output, **kwargs)
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tests/runner.py", line 1117, in do_run_from_file
    self.do_run(open(src).read(), open(expected_output).read(), *args, **kwargs)
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tests/runner.py", line 1141, in do_run
    build_ll_hook=build_ll_hook, post_build=post_build)
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tests/runner.py", line 677, in build
    run_process(args, stderr=self.stderr_redirect if not DEBUG else None)
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tools/shared.py", line 188, in run_process
    result.check_returncode()
  File "/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/tools/shared.py", line 168, in check_returncode
    raise Py2CalledProcessError(returncode=self.returncode, cmd=self.args, output=self.stdout, stderr=self.stderr)
Py2CalledProcessError: Command '['/nix/store/984x0xnjaf00ms5nh1r1ki3h6qd5q399-python-2.7.18/bin/python', '/nix/store/rl99nm7c9gi02yijrpalqgkmvg32j352-source/emcc.py', '-Werror', '-O0', '-Wno-dynamic-class-memaccess', '-Wno-format', '-Wno-format-extra-args', '-Wno-format-security', '-Wno-pointer-bool-conversion', '-Wno-unused-volatile-lvalue', '-Wno-c++11-compat-deprecated-writable-strings', '-Wno-invalid-pp-token', '-Wno-shift-negative-value', '-I/build/emscripten_test_wasm0_zfIApd', '-I/build/emscripten_test_wasm0_zfIApd/include', '/build/emscripten_test_wasm0_zfIApd/src.c', '-o', '/build/emscripten_test_wasm0_zfIApd/src.c.o.js']' returned non-zero exit status 1

----------------------------------------------------------------------
Ran 1 test in 1.112s

FAILED (errors=1)
builder for '/nix/store/734iyf5p8nbc3ld1cjmjk6vqj18vk9l2-emscripten-1.39.1.drv' failed with exit code 1

@gebner gebner mentioned this pull request Aug 29, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@asppsa asppsa asppsa approved these changes

@qknight qknight Awaiting requested review from qknight

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nkpart @leo60228 @breakds @magnetophon @matthewbauer @asppsa @alyssais