Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 99d1c0a2701a
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 8185415b55a4
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Dec 16, 2019

  1. python: remove _manylinux.py 

    This will turn manylinux support back on by default.

PIP will now do runtime checks against the compatible glibc version to
determine if the current interpreter is compatible with a given
manylinux specification. However it will not check if any of the
required libraries are present.

The motivation here is that we want to support building python packages
with wheels that require manylinux support. There is no real change for
users of source builds as they are still buildings packages from source.

The real noticeable(?) change is that impure usages (e.g. running `pip
install package`) will install manylinux packages that previously
refused to install.
Previously we did claim that we were not compatible with manylinux and
thus they wouldn't be installed at all.

Now impure users will have basically the same situation as before: If
you require some wheel only package it didn't work before and will not
properly work now. Now the program will fail during runtime vs during
installation time.

I think it is a reasonable trade-off since it allows us to install
manylinux packages with nix expressions and enables tools like
poetry2nix.

This should be a net win for users as it allows wheels, that we
previously couldn't really support, to be used.
    @andir
    andir committed Dec 16, 2019
    Copy the full SHA
    e9f522e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #75763 from gilligan/manylinux-interp 

    python: remove _manylinux.py
    @andir
    andir committed Dec 16, 2019
    Copy the full SHA
    8185415 View commit details
    Browse the repository at this point in the history