ruby-modules: parse build_flags correctly #75804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In building a gem whose native extension is a Rakefile, the previous version of this code will call essentially
rake ""
, when it means to callrake
. This breaks the intent to call the default task.This change converts
""
into[]
rather than[""]
, and probably un-breaks conditions where we're trying to pass multiple flags, since bundler/rubygems seems to want them as an array of flags.cc @aneeshusa @zimbatm