Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errbot: fix darwin tests #75791

Closed
wants to merge 1 commit into from
Closed

errbot: fix darwin tests #75791

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 16, 2019 •
edited

Motivation for this change

noticed it was failing in another PR

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 16, 2019
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build errbot

@ofborg ofborg bot requested review from globin and fpletz December 16, 2019 20:41
@LnL7
Copy link
Member

LnL7 commented Dec 17, 2019

Seems like there are more tests that are unreliable or fail in the sandbox.

@jonringer
Copy link
Contributor Author

Yea, going to do a proper fix, 2s

@jonringer
Copy link
Contributor Author

lost interest in darwin use case

@jonringer jonringer closed this Feb 18, 2020
@jonringer jonringer deleted the fix-darwin-errbot branch February 18, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @LnL7