Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gleam: init at 0.5.0 #75814

Merged
merged 1 commit into from Dec 18, 2019
Merged

gleam: init at 0.5.0 #75814

merged 1 commit into from Dec 18, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 17, 2019 •
edited

Motivation for this change

Close #71432.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @NobbZ

This change is Reviewable

jonringer
jonringer approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
repo look good
executable shows usage

[4 built, 3 copied (502.3 MiB), 185.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75814
1 package were built:
gleam

jonringer
jonringer reviewed Dec 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fix darwin build

pkgs/development/compilers/gleam/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/gleam/default.nix Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@Br1ght0ne @NobbZ
gleam: init at 0.5.0
a866b61 
Close NixOS#71432.

Co-authored-by: Norbert Melzer <NobbZ@users.noreply.github.com>
@jonringer
Copy link
Contributor

still LGTM

@jonringer jonringer merged commit aed6f88 into NixOS:master Dec 18, 2019
@Br1ght0ne Br1ght0ne deleted the gleam-0.5.0 branch December 18, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Br1ght0ne @jonringer