Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update bundler version #114

Merged
merged 1 commit into from Dec 17, 2019
Merged

Fix: update bundler version #114

merged 1 commit into from Dec 17, 2019

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Dec 17, 2019 •
edited

Docker build is broken since december 16th (rubygems updated from 3.0.6 to 3.1.1, including an update for bundler from 1.17.3 to 2.1.0).
I don't know if it's the right fix, but it works :)
Other option is to install older bundler.

@glx22 glx22 requested a review from TrueBrain December 17, 2019 14:07
TrueBrain
TrueBrain approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, let's ship it. I am not a Ruby guru of any kind .. just happy if it works :P

Reminds me we should bump dependencies some day .. not this day :D

@TrueBrain TrueBrain merged commit 53ce595 into OpenTTD:master Dec 17, 2019
@glx22 glx22 deleted the fix_farm branch December 17, 2019 21:38
@auge8472 auge8472 mentioned this pull request Dec 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glx22 @TrueBrain