Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remmina: 1.3.4 -> 1.3.7 #75811

Merged
merged 1 commit into from Dec 18, 2019
Merged

remmina: 1.3.4 -> 1.3.7 #75811

merged 1 commit into from Dec 18, 2019

Conversation

worldofpeace
Copy link
Contributor

According to the release notes this is a
"This release is meant to prepare the stable release for January, before the freeze in Debian an Ubuntu ".
Not sure what that means, but I expect a stable release
in NixOS 20.03 for sure.

https://gitlab.com/Remmina/Remmina/-/tags/v1.3.7

Motivation for this change

#75790

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
remmina: 1.3.4 -> 1.3.7
586df03 
According to the release notes this is a
"This release is meant to prepare the stable release for January, before the freeze in Debian an Ubuntu ".
Not sure what that means, but I expect a stable release
in NixOS 20.03 for sure.

https://gitlab.com/Remmina/Remmina/-/tags/v1.3.7
@worldofpeace worldofpeace changed the title remmina: 1.3.4 - 1.3.7 remmina: 1.3.4 -> 1.3.7 Dec 17, 2019
@ofborg ofborg bot requested a review from ryantm December 17, 2019 06:54
jonringer
jonringer approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
gui's seem to launch fine

[3 built, 7 copied (8.9 MiB), 2.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75811
1 package were built:
remmina

@gebner gebner merged commit d942688 into NixOS:master Dec 18, 2019
@worldofpeace worldofpeace deleted the pango-fix-builds branch December 18, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jonringer @gebner