Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 12.5.4 -> 12.5.5 #75834

Merged
merged 1 commit into from Dec 19, 2019
Merged

gitlab: 12.5.4 -> 12.5.5 #75834

merged 1 commit into from Dec 19, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Dec 17, 2019 •
edited

Things done
  • Tested basic functionality manually in VM.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli @globin @fpletz @petabyteboy

@talyz
Copy link
Contributor Author

talyz commented Dec 17, 2019

@GrahamcOfBorg test gitlab

@ghost ghost mentioned this pull request Dec 17, 2019
Closed
10 tasks
@ghost
Copy link

ghost commented Dec 17, 2019

I ran the NixOS test, LGTM :)

@flokli flokli merged commit 1c15955 into NixOS:master Dec 19, 2019
@flokli
Copy link
Contributor

flokli commented Dec 19, 2019

backported to 19.09 in dd26550.

@talyz talyz deleted the gitlab-12.5.5 branch December 20, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @flokli