cut-the-crap: init at 1.0.0 #75794

jappeace · 2019-12-16T20:54:27Z

Motivation for this change

Adds a useful automated video editing tool for streamers.

Things done

Notify maintainers

I think I'm the maintainer of this package

cc @

cdepillabout · 2020-01-12T00:57:47Z

@jappeace Would you consider releasing this to Hackage?

That way, it would get updates automatically here in nixpkgs whenever you released a new version.

jappeace · 2020-01-13T19:57:58Z

Hi @cdepillabout I uploaded it to hackage.
It still needs ffmpeg as a runtime dependency, how does one add that?

cdepillabout · 2020-01-14T00:31:24Z

@jappeace Thanks!

Next time the hackage packages are updated on the haskell-updates branch, you should be able to see cut-the-crap. You'll be able to try to build it with a command like nix-build -A haskellPackages.cut-the-crap.

It still needs ffmpeg as a runtime dependency, how does one add that?

You should be able to add that with a wrapper script. Here's an example:

nixpkgs/pkgs/development/haskell-modules/configuration-nix.nix

Lines 585 to 593 in a8144b1

    
               in overrideCabal (addBuildTool super.futhark makeWrapper) (_drv: { 
        
                 postInstall = '' 
        
                   wrapProgram $out/bin/futhark \ 
        
                     --prefix PATH : "${path}" \ 
        
                     --set NIX_CC_WRAPPER_x86_64_unknown_linux_gnu_TARGET_HOST 1 \ 
        
                     --set NIX_CFLAGS_COMPILE "-I${opencl-headers}/include" \ 
        
                     --set NIX_CFLAGS_LINK "-L${ocl-icd}/lib" 
        
                 ''; 
        
               });

For cut-the-crap, it might look something like this:

  cut-the-crap =
    let path = stdenv.lib.makeBinPath [ ffmpeg ];
    in overrideCabal (addBuildTool super.cut-the-crap makeWrapper) (_drv: {
      postInstall = ''
        wrapProgram $out/bin/cut-the-crap \
          --prefix PATH : "${path}"
      '';
    });

doronbehar · 2020-02-23T17:52:27Z

pkgs/applications/video/cut-the-crap/default.nix

+    system-filepath temporary text unliftio-core
+  ];
+  prePatch = "hpack";
+  license = stdenv.lib.licenses.mit;


Why is there no meta as with any regular derivation? Maybe I'm just not familiar with the Haskell ecosystem...

This is generated, but at the moment I'm waiting for haskellPackages to be updated so I can just do cdepillabout's suggestion.

doronbehar · 2020-02-23T17:52:28Z

pkgs/applications/video/cut-the-crap/default.nix

+  src = fetchgit {
+    url = "https://github.com/jappeace/cut-the-crap";
+    sha256 = "1z4s0zan421q4722k32p0n33bsh7di1m6pbbdzqi7j87lfd9i7nk";
+    rev = "0ea8a0a0fd3e8d85f44337f13ef2445d22d1bf97";


Why not use https://github.com/jappeace/cut-the-crap/releases/tag/1.0.0 ?

I made this before that debian thing. I wouldn't know how to use tags, or do you just mean the same commit as that tag?

Maybe that's also automatically generated... I'll leave this review to someone else more familiar with Haskell :)

turion · 2020-04-16T10:21:43Z

@cdepillabout didn't you mean stackage, not hackage?

cdepillabout · 2020-04-16T11:13:43Z

@turion What are you referring to?

cut-the-crap was originally not uploaded to Hackage, so it didn't automatically appear in the Haskell package set here in nixpkgs.

However, it appears that @jappeace has since uploaded to Hackage, so now it should be easy to just use haskellPackages.cut-the-crap.

Although you're right that uploading to Stackage (in addition to Hackage) would make it easier to make sure cut-the-crap builds here in nixpkgs.

turion · 2020-04-16T11:54:19Z

@cdepillabout Thanks for the clarification! I can never remember how, in which files, and in which workflow either hackage or stackage are crawled. (Wish this was documented.)

cdepillabout · 2020-04-16T12:04:00Z

@turion Yeah, I definitely sympathize!

A (very short) explanation is that Haskell packages are updated from Hackage automatically on a daily basis in this file:

https://github.com/NixOS/nixpkgs/blob/16477d764f375ef7b81acbfd13189299ff67f233/pkgs/development/haskell-modules/hackage-packages.nix

The packages in the stackage resolver are specified here:

nixpkgs/pkgs/development/haskell-modules/configuration-hackage2nix.yaml

Lines 45 to 80 in 16477d7

    
           # This is a list of packages with versions from the latest Stackage LTS release. 
        
           # 
        
           # The packages and versions in this list cause the `hackage2nix` tool to 
        
           # generate the package at the given version. 
        
           # 
        
           # For instance, with a line like the following: 
        
           # 
        
           # - aeson ==1.4.6.0 
        
           # 
        
           # `hackage2nix` will generate the `aeson` package at version 1.4.6.0 in the 
        
           # ./hackage-packages.nix file. 
        
           # 
        
           # Since the packages in the LTS package set are sometimes older than the latest 
        
           # on Hackage, `hackage2nix` is smart enough to also generate the latest version 
        
           # of a given package. 
        
           # 
        
           # In the above example with aeson, if there was version 1.5.0.0 of aeson 
        
           # available on Hackage, `hackage2nix` would generate two packages, `aeson` 
        
           # at version 1.4.6.0 and `aeson_1_5_0_0` at version 1.5.0.0. 
        
           # 
        
           # WARNING: This list is generated semiautomatically based on the most recent 
        
           # LTS package set. If you want to add entries to it, you must do so before the 
        
           # comment saying "# LTS Haskell x.y". Any changes after that commend will be 
        
           # lost the next time `update-stackage.sh` runs. 
        
           default-package-overrides: 
        
             # This was only intended for ghc-7.0.4, and has very old deps, one hidden behind a flag 
        
             - MissingH ==1.4.2.0 
        
             # gi-gdkx11-4.x requires gtk-4.x, which is still under development and 
        
             # not yet available in Nixpkgs 
        
             - gi-gdkx11 < 4 
        
             # LTS Haskell 15.7 
        
             - abstract-deque ==0.3 
        
             - abstract-par ==0.3.3 
        
             - AC-Angle ==1.0 
        
             - accuerr ==0.2.0.2 
        
             - ace ==0.6

This list is updated once a week or so by peti. I believe he does it semi-automatically.

That file also has a bunch of other settings for special things to do when updating packages from Hackage.

jappeace · 2020-04-16T12:05:02Z

I'll fix this up right now as discussed above (eg use haskellPackages)

jappeace · 2020-04-16T12:31:22Z

Ok nice, that's a lot less code and it makes updating this as simple as re-uploading to hackage. Thanks for all the help @cdepillabout

cdepillabout · 2020-04-17T00:16:09Z

@jappeace One more thing. Could you rebase this on the haskell-updates branch, and change the base branch for this PR here on GitHub to haskell-updates?

We like to have most Haskell-related changes going to the haskell-updates branch.

This reverts commit fe6addb.

This is really essential thing that everyone should be doing. A few extra notifications won't hurt anyone, and we should be tracking issues to connect them to the best people who can handle them. Co-Authored-By: Cole Helbling <cole.e.helbling@outlook.com>

jappeace · 2020-04-17T10:26:04Z

lol, that upsets github quite a bit @cdepillabout

jappeace · 2020-04-17T10:48:22Z

I kindly refer you to #85438

Sorry for everyone else who got tagged. I didn't expect github to be so un-intelligent.

doronbehar · 2020-04-17T12:26:28Z

@jappeace please mind your language 🙏 . It's 1 thing we add here a program that has "crap" in it's name - it doesn't mean we have to use such words when we deal with them.

jappeace · 2020-04-17T12:29:45Z

@doronbehar I already self censored. You probably had a tab open or something.

doronbehar · 2020-04-17T12:39:14Z

I noticed that and I still felt it was necessary to put it. I was subscribed to this issue and I got that by email.

ofborg bot added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 16, 2019

jappeace force-pushed the master branch from 1a3b018 to ba1ac0d Compare December 19, 2019 20:00

jappeace changed the title ~~cut-the-crap: Add automated video editing for streamers at 1.0.0~~ cut-the-crap: init at 1.0.0 Dec 19, 2019

aanderse requested a review from cdepillabout January 11, 2020 20:54

cdepillabout added the 6.topic: haskell label Jan 12, 2020

doronbehar reviewed Feb 23, 2020

View reviewed changes

jappeace force-pushed the master branch from ba1ac0d to 6db42ea Compare April 16, 2020 12:15

ofborg bot added 10.rebuild-darwin: 1 10.rebuild-linux: 1 and removed 6.topic: haskell labels Apr 16, 2020

jappeace force-pushed the master branch from 6db42ea to 0ad2ebf Compare April 16, 2020 12:29

jappeace requested a review from infinisil as a code owner April 16, 2020 12:29

ofborg bot added the 6.topic: haskell label Apr 16, 2020

andir and others added 5 commits April 17, 2020 11:58

buildRustCrate: support proc-macro in default prelude

0756ff5

Revert "riot-desktop: wrap with wrapGAppsHook"

62da8af

This reverts commit fe6addb.

electron: fix wrapGAppsHook usage

b080a7d

ulauncher: 5.6.1 -> 5.7.3

3000f81

jappeace requested review from matthewbauer, nbp and ttuegel as code owners April 17, 2020 10:18

ofborg bot added 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion 6.topic: python 6.topic: qt/kde 6.topic: rust 6.topic: xfce The Xfce Desktop Environment 8.has: documentation 8.has: module (update) 2.status: merge conflict labels Apr 17, 2020

jappeace changed the base branch from master to haskell-updates April 17, 2020 10:24

ofborg bot added 8.has: clean-up 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 501-1000 and removed 2.status: merge conflict 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Apr 17, 2020

jappeace closed this Apr 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cut-the-crap: init at 1.0.0 #75794

cut-the-crap: init at 1.0.0 #75794

jappeace commented Dec 16, 2019 •

edited

cdepillabout commented Jan 12, 2020

jappeace commented Jan 13, 2020

cdepillabout commented Jan 14, 2020 •

edited

doronbehar Feb 23, 2020

jappeace Feb 24, 2020

doronbehar Feb 23, 2020

jappeace Feb 24, 2020

doronbehar Feb 25, 2020 •

edited

turion commented Apr 16, 2020

cdepillabout commented Apr 16, 2020 •

edited

turion commented Apr 16, 2020

cdepillabout commented Apr 16, 2020

jappeace commented Apr 16, 2020 •

edited

jappeace commented Apr 16, 2020

cdepillabout commented Apr 17, 2020

jappeace commented Apr 17, 2020

jappeace commented Apr 17, 2020 •

edited

doronbehar commented Apr 17, 2020

jappeace commented Apr 17, 2020

doronbehar commented Apr 17, 2020

cut-the-crap: init at 1.0.0 #75794

cut-the-crap: init at 1.0.0 #75794

Conversation

jappeace commented Dec 16, 2019 • edited

Motivation for this change

Things done

Notify maintainers

cdepillabout commented Jan 12, 2020

jappeace commented Jan 13, 2020

cdepillabout commented Jan 14, 2020 • edited

doronbehar Feb 23, 2020

Choose a reason for hiding this comment

jappeace Feb 24, 2020

Choose a reason for hiding this comment

doronbehar Feb 23, 2020

Choose a reason for hiding this comment

jappeace Feb 24, 2020

Choose a reason for hiding this comment

doronbehar Feb 25, 2020 • edited

Choose a reason for hiding this comment

turion commented Apr 16, 2020

cdepillabout commented Apr 16, 2020 • edited

turion commented Apr 16, 2020

cdepillabout commented Apr 16, 2020

jappeace commented Apr 16, 2020 • edited

jappeace commented Apr 16, 2020

cdepillabout commented Apr 17, 2020

jappeace commented Apr 17, 2020

jappeace commented Apr 17, 2020 • edited

doronbehar commented Apr 17, 2020

jappeace commented Apr 17, 2020

doronbehar commented Apr 17, 2020

jappeace commented Dec 16, 2019 •

edited

cdepillabout commented Jan 14, 2020 •

edited

doronbehar Feb 25, 2020 •

edited

cdepillabout commented Apr 16, 2020 •

edited

jappeace commented Apr 16, 2020 •

edited

jappeace commented Apr 17, 2020 •

edited