Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port NixOS tests to python #75795

Merged
merged 3 commits into from Dec 18, 2019
Merged

Port NixOS tests to python #75795

merged 3 commits into from Dec 18, 2019

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Dec 16, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

@nh2
Copy link
Contributor

nh2 commented Dec 16, 2019

@GrahamcOfBorg test nixosTests.hadoop.hdfs nixosTests.hadoop.yarn nixosTests.hitch

@nh2
Copy link
Contributor

nh2 commented Dec 16, 2019

@GrahamcOfBorg test hadoop.hdfs hadoop.yarn hitch

@kampka
Copy link
Contributor Author

kampka commented Dec 17, 2019

@GrahamcOfBorg test hadoop.hdfs
@GrahamcOfBorg test hadoop.yarn
@GrahamcOfBorg test hitch

nh2
nh2 approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass.

@nh2 nh2 merged commit f7b6824 into NixOS:master Dec 18, 2019
@kampka
Copy link
Contributor Author

kampka commented Dec 18, 2019

@nh2 Thanks for reviewing 👍

@kampka kampka deleted the port-tests-4 branch December 18, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kampka @nh2