Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: add xdg_utils to the PATH #75825

Merged
merged 1 commit into from Dec 17, 2019
Merged

slack: add xdg_utils to the PATH #75825

merged 1 commit into from Dec 17, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 17, 2019 •
edited

Otherwise it cannot log in to new workspaces.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@grahamc
slack: add xdg_utils to the PATH
7e92939 
Otherwise it cannot log in to new workspaces.
@ofborg ofborg bot requested a review from mmahut December 17, 2019 17:13
@grahamc grahamc merged commit 529cd90 into NixOS:master Dec 17, 2019
@grahamc grahamc deleted the slack branch December 17, 2019 21:03
grahamc added a commit to grahamc/nixos-config that referenced this pull request Dec 20, 2019
@grahamc
slack: add xdg_utils, see NixOS/nixpkgs#75825
c208ce3
@layus layus mentioned this pull request Jan 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@grahamc