Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gegl_0_4: add patch for test timeouts #75773

Merged
merged 1 commit into from Dec 29, 2019
Merged

gegl_0_4: add patch for test timeouts #75773

merged 1 commit into from Dec 29, 2019

Conversation

worldofpeace
Copy link
Contributor

Commit message

This has failed at the checkPhase many times
on hydra due to a timeout in a particular testcase.
I'm unable to identify which testcase it is within the
source from the output, but I usually place winning
bets on debian patches.

Motivation for this change

Too many occasions has the gnome3 tests failed because of gegl job timing out on a test.
https://hydra.nixos.org/build/108422657
https://hydra.nixos.org/build/108162813
https://hydra.nixos.org/build/108162815
https://hydra.nixos.org/build/108095634

Other times it's checking for references to /build/ in /nix/store/k4gy2675j79g72hlj5ch2sjgxjh23abc-gegl-0.4.18-devdoc... which is annoying enough for me to notice at this point.

I'm not sure it fixes anything in NixOS, so please be critical.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
gegl_0_4: add patch for test timeouts
ff15346 
This has failed at the checkPhase many times
on hydra due to a timeout in a particular testcase.
I'm unable to identify which testcase it is within the
source from the output, but I usually place winning
bets on debian patches.
jtojnar
jtojnar approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it can't hurt.

@gebner
Copy link
Member

gebner commented Dec 29, 2019

And there was a timeout again: https://hydra.nixos.org/build/108819624/nixlog/2 Let's try this.

@gebner gebner merged commit 0db351f into NixOS:master Dec 29, 2019
@lovesegfault
Copy link
Member

I don't think this fixed it.

@gebner
Copy link
Member

gebner commented Jan 2, 2020

Indeed, the patch only changes the timeout for the ff-load-save test, which we don't even run?! Our gegl builds always fail in the simple / backend-file test.

@lovesegfault lovesegfault mentioned this pull request Jan 2, 2020
Merged
10 tasks
@worldofpeace worldofpeace deleted the gegl-timeout-fix-maybe branch January 6, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @gebner @lovesegfault @jtojnar