Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nncp: init at 5.3.3 #75772

Merged
merged 1 commit into from Sep 26, 2020
Merged

nncp: init at 5.3.3 #75772

merged 1 commit into from Sep 26, 2020

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Dec 16, 2019

Motivation for this change

use NNCP, a UUCP-like store-and-forward toolset with crypto, written in go

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@woffs woffs force-pushed the pr-nncp branch 2 times, most recently from 1925c89 to ab45790 Compare December 28, 2019 19:00
@woffs woffs changed the title nncp: init at 5.2.1 nncp: init at 5.3.2 Dec 28, 2019
@woffs woffs changed the title nncp: init at 5.3.2 nncp: init at 5.3.3 Feb 13, 2020
doronbehar
doronbehar reviewed Feb 23, 2020
View reviewed changes
pkgs/tools/misc/nncp/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/nncp/default.nix Show resolved Hide resolved
pkgs/tools/misc/nncp/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/nncp/default.nix Show resolved Hide resolved
@woffs
Copy link
Contributor Author

woffs commented Feb 23, 2020

Thanks @doronbehar for reviewing! I've just pulled the small corrections and rebased to master.

@woffs
Copy link
Contributor Author

woffs commented May 15, 2020

(rebased to current master)

doronbehar
doronbehar approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my friend that your PR is waiting so long :) This is how things are in Nixpkgs unfortunately.

@woffs
Copy link
Contributor Author

woffs commented Sep 25, 2020

rebased to current master, still compiles and runs.

doronbehar
doronbehar requested changes Sep 25, 2020
View reviewed changes
pkgs/tools/misc/nncp/default.nix Show resolved Hide resolved
pkgs/tools/misc/nncp/default.nix Outdated Show resolved Hide resolved
@doronbehar
Copy link
Contributor

The eval error has nothing to do with you.

doronbehar
doronbehar requested changes Sep 26, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last round of review, I promise!

pkgs/tools/misc/nncp/default.nix Outdated Show resolved Hide resolved
@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 75772 1

1 package built:
  • nncp

doronbehar
doronbehar approved these changes Sep 26, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review build and --help tests.

@doronbehar doronbehar merged commit 3777229 into NixOS:master Sep 26, 2020
@doronbehar
Copy link
Contributor

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@woffs @doronbehar