Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vector: enable rdkafka feature #75767

Merged
merged 2 commits into from Dec 20, 2019
Merged

vector: enable rdkafka feature #75767

merged 2 commits into from Dec 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 16, 2019

Motivation for this change

This PR enables rdkafka feature for Vector package. It is achieved by using cmake as the build system for librdkafka (enabled using rdkafka/cmake_build feature), which is more flexible about than the default build script coming with librdkafka.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice

@ofborg ofborg bot requested a review from thoughtpolice December 16, 2019 16:31
thoughtpolice
thoughtpolice reviewed Dec 16, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to reuse the existing rdkafka package, rather than having the Rust Crate build an entirely separate copy in the background? This will make the build closure smaller and probably improve build times a bit.

When I tried it, it was particularly annoying for some reason, but CMake may handle it better?

@ofborg ofborg bot requested a review from thoughtpolice December 17, 2019 10:59
@ghost
Copy link
Author

ghost commented Dec 17, 2019

I've updated the PR to use rdkafka/dynamic_linking feature which uses the existing rdkafka package.

@binarylogic binarylogic mentioned this pull request Dec 19, 2019
Closed
1 task
@thoughtpolice thoughtpolice merged commit c062839 into NixOS:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thoughtpolice @Janik-Haag