Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat: Fix build on Darwin (TCL fix also) #75770

Closed
wants to merge 1 commit into from
Closed

weechat: Fix build on Darwin (TCL fix also) #75770

wants to merge 1 commit into from

Conversation

eraserhd
Copy link
Contributor

Darwin weechat needs gettext.

Also, the TCL derivation assumes dlls end with .so even on Darwin, which causes it to create a dangling symlink. The weechat changelog indicates that the mechanism for detecting the library location has changed in this version, and the new version tries to link against the dangling symlink, causing it to fail.

The TCL bit causes a lot of rebuilds, so this PR is to staging.

Motivation for this change

Update of weechat derivation broke building on Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

weechat cc @lovek323 @the-kenny @lheckemann @Ma27
tcl cc @vrthra

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 16, 2019
@eraserhd
Copy link
Contributor Author

I just figured out a way to do this that won't cause so many rebuilds, so I'm closing this and will make a different PR.

@eraserhd eraserhd closed this Dec 16, 2019
@eraserhd eraserhd deleted the weechat-darwin-build branch December 16, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

@vrthra vrthra Awaiting requested review from vrthra

@lovek323 lovek323 Awaiting requested review from lovek323

@Ma27 Ma27 Awaiting requested review from Ma27

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eraserhd