Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new vim plugins #75769

Merged
merged 5 commits into from Dec 16, 2019
Merged

Add new vim plugins #75769

merged 5 commits into from Dec 16, 2019

Conversation

softinio
Copy link
Member

Motivation for this change

Added vim plugins missing from pkgs:

  • gorkunov/smartpairs.vim
  • jsfaint/gen_tags.vim
  • junegunn/vim-slash
  • vimlab/split-term.vim

Also existing plugins updated.

All as a separate commit as per @jonringer request here: #75683 - Thank you !

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonringer

@softinio softinio changed the title Add new vim plugins 3 Add new vim plugins Dec 16, 2019
@ofborg ofborg bot requested a review from jagajaga December 16, 2019 16:41
jonringer
jonringer approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

[29 built, 33 copied (1022.6 MiB), 237.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75769
14 package were built:
vimPlugins.coc-go vimPlugins.gen_tags-vim vimPlugins.ghcid vimPlugins.nerdtree vimPlugins.smartpairs-vim vimPlugins.split-term-vim vimPlugins.vim-airline vimPlugins.vim-fireplace vimPlugins.vim-go vimPlugins.vim-lsc vimPlugins.vim-slash vimPlugins.vim-terraform vimPlugins.vimtex vimPlugins.youcompleteme

@jonringer jonringer merged commit ce2adeb into NixOS:master Dec 16, 2019
@jonringer
Copy link
Contributor

oh, the commit name names... should have been:

Add gen_tags vim plugin -> vimPlugins.gen_tags: init at YYYY-MM-DD
...
oops

@softinio
Copy link
Member Author

oh, the commit name names... should have been:

Add gen_tags vim plugin -> vimPlugins.gen_tags: init at YYYY-MM-DD
...
oops

@jonringer oh didn't know .... learnt something new for next time. Thanks for your help.

@softinio softinio deleted the add-new-vim-plugins-3 branch December 17, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@softinio @jonringer