Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kpat: init at 19.12.0 #75846

Merged
merged 1 commit into from Dec 18, 2019
Merged

kpat: init at 19.12.0 #75846

merged 1 commit into from Dec 18, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Dec 17, 2019

Motivation for this change

Needed a card game on NixOS, also #62168.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

what is this compiling? there's no src. lol

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 18, 2019

what is this compiling? there's no src. lol

It's a KDE application: the source is defined in pkgs/applications/kde/srcs/nix and the build is done using a modified mkDerivation.

@7c6f434c 7c6f434c merged commit c551f2d into NixOS:master Dec 18, 2019
@7c6f434c
Copy link
Member

Of course the motivation is weak as we all know PySol has more rulesets in it (but I have to admit it has so many it is easier to get lost in the choice there).

@rnhmjoj rnhmjoj deleted the kpatience branch January 8, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @jonringer @7c6f434c