libreoffice: merge -still and -fresh into common expression #75850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to refactor the packages so that most of their build expression is shared. Each variant of LibreOffice gets its own subdirectory
src-$variant/
where files w/ source references are stored. In the directory is alsooverride.nix
which allows you to override derivation attributes in addition to source files.The derivation of the -fresh package doesn't change so it doesn't get rebuilt. For the -still package I believe the changes are harmless (still building it though):
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @7c6f434c @peterhoeg