nodePackages.dat :init at 13.13.1 #75832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nodepackages-dat-init-at-13-13-1/5135/1 |
|
I think you add an entry in |
lilyball
reviewed
Dec 17, 2019
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| {pkgs ? import <nixpkgs> { | |||
| inherit system; | |||
| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-13_x"}: | |||
| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-8_x"}: | |||
| @@ -363,7 +363,7 @@ let | |||
|
|
|||
| npm ${forceOfflineFlag} --nodedir=${nodeSources} ${npmFlags} ${stdenv.lib.optionalString production "--production"} rebuild | |||
|
|
|||
| if [ "''${dontNpmInstall-}" != "1" ] | |||
| if [ "$dontNpmInstall" != "1" ] | |||
There was a problem hiding this comment.
This will produce an error if $dontNpmInstall is unset and set -u is enabled (which I think it is by default for stdenv packages, not sure about node packages).
|
Even with @lilyball 's suggestion I still get the following error: |
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
|
BTW if you wrap your long outputs in a <details><summary>Description goes here</summary>
markdown contents goes here
</details>(the blank lines are to ensure block-level markdown inside the tag is parsed) This renders like Description goes hereecho "this is your contents" |
|
The error is coming from |
|
Even with |
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
|
Curious, when I try to build If I try to build As for the error I printed, looking at this file there's two different In any case, given how this works, declaring the |
|
My latest attempt is with the following diff (note: I removed diff --git a/pkgs/development/node-packages/default-v13.nix b/pkgs/development/node-packages/default-v13.nix
index a5bc1c8e1ad..93c45ffa4ce 100644
--- a/pkgs/development/node-packages/default-v13.nix
+++ b/pkgs/development/node-packages/default-v13.nix
@@ -13,7 +13,7 @@ nodePackages // {
wrapProgram "$out/bin/node2nix" --prefix PATH : ${stdenv.lib.makeBinPath [ pkgs.nix ]}
'';
};
- sodium-native = nodePackages.sodium-native.override {
- buildInputs = [ nodePackages.node-gyp-build pkgs.libtool ];
+ dat = nodePackages.dat.override {
+ nativeBuildInputs = [ nodePackages.node-gyp-build ];
};
}
diff --git a/pkgs/development/node-packages/node-packages-v13.json b/pkgs/development/node-packages/node-packages-v13.json
index f4947938390..a6576f47328 100644
--- a/pkgs/development/node-packages/node-packages-v13.json
+++ b/pkgs/development/node-packages/node-packages-v13.json
@@ -1,5 +1,5 @@
[
"node2nix",
- "dat" ,
- "sodium-native"
+ "dat",
+ "node-gyp-build"
]
diff --git a/pkgs/development/node-packages/node-packages-v13.nix b/pkgs/development/node-packages/node-packages-v13.nix
index a11eacd0fde..fc3939164f7 100644
--- a/pkgs/development/node-packages/node-packages-v13.nix
+++ b/pkgs/development/node-packages/node-packages-v13.nix
@@ -5269,23 +5269,18 @@ in
bypassCache = true;
reconstructLock = true;
};
- sodium-native = nodeEnv.buildNodePackage {
- name = "sodium-native";
- packageName = "sodium-native";
- version = "2.4.6";
+ node-gyp-build = nodeEnv.buildNodePackage {
+ name = "node-gyp-build";
+ packageName = "node-gyp-build";
+ version = "4.2.0";
src = fetchurl {
- url = "https://registry.npmjs.org/sodium-native/-/sodium-native-2.4.6.tgz";
- sha512 = "Ro9lhTjot8M01nwKLXiqLSmjR7B8o+Wg4HmJUjEShw/q6XPlNMzjPkA1VJKaMH8SO8fJ/sggAKVwreTaFszS2Q==";
+ url = "https://registry.npmjs.org/node-gyp-build/-/node-gyp-build-4.2.0.tgz";
+ sha512 = "4oiumOLhCDU9Rronz8PZ5S4IvT39H5+JEv/hps9V8s7RSLhsac0TCP78ulnHXOo8X1wdpPiTayGlM1jr4IbnaQ==";
};
- dependencies = [
- sources."ini-1.3.5"
- sources."nan-2.14.0"
- sources."node-gyp-build-4.2.0"
- ];
buildInputs = globalBuildInputs;
meta = {
- description = "Low level bindings for libsodium";
- homepage = https://github.com/sodium-friends/sodium-native;
+ description = "Build tool and bindings loader for node-gyp that supports prebuilds";
+ homepage = https://github.com/prebuild/node-gyp-build;
license = "MIT";
};
production = true;For some reason this produces compilation errors. I don't know if Full log |
|
cc @svanderburg |
|
Apparently if I install dat via npm -g I get no troubles and |
|
Apparently dat was already in nixpkgs in node-packages-v10.json,but it does not compile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
Buld fails with the following error:
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @