Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtv: remove #75821

Closed
wants to merge 1 commit into from
Closed

rtv: remove #75821

wants to merge 1 commit into from

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 17, 2019

Motivation for this change

See #75817.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer


This change is Reviewable

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not approve.

rtv is still working. We should not remove it. IMO, we should just mark it as deprecated somehow (again: Is there a process for deprecating a package?).

@Br1ght0ne
Copy link
Member Author

is there a process for deprecating a package?

Not that I know of, sadly.

@matthiasbeyer
Copy link
Contributor

Well, yeah, seems like there is no way. It seems that adding "(deprecated)" to the description of the package would be the first step.

We should definitively not just remove the package, as this might break nixos updates for people. I'd rather set the description to "(deprecated)" and, in the next release (nixos-20.03) remove rtv, but not like in the middle of the nixos year.

Maybe I would even schedule the removal for 20.09 rather than 20.03, because rtv still works afaik.

@wedens
Copy link

wedens commented Dec 17, 2019

I agree with @matthiasbeyer that we should keep rtv while it works.

@Ma27
Copy link
Member

Ma27 commented Dec 19, 2019

Not that I know of, sadly.

IIRC we basically throw an error (as you did) and add a note in the release-notes for the upcoming release.

@aanderse
Copy link
Member

@filalex77 now that #75817 is merged can you please update this PR to mention tuir and then we can merge? @Ma27 - sound good to you?

@stale
Copy link

stale bot commented Jul 9, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unpriviledged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 9, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Jun 6, 2021

Should still be removed (marked as deprecated).

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@bobby285271
Copy link
Member

#133085 already removed.

@Br1ght0ne Br1ght0ne deleted the remove-rtv branch September 18, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants